Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement SubmitRollupTransaction and GetNextBatch methods #14

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: implement SubmitRollupTransaction and GetNextBatch methods #14

wants to merge 8 commits into from

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Sep 30, 2024

Overview

Resolves #4
Resolves #5

@tzdybal tzdybal self-assigned this Sep 30, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tzdybal tzdybal added the enhancement New feature or request label Sep 30, 2024
@tzdybal tzdybal changed the title Implement SubmitRollupTransaction and GetNextBatch methods feat: implement SubmitRollupTransaction and GetNextBatch methods Sep 30, 2024
@tzdybal
feat: WIP implementation - return a single batch
eebd330 
WIP. Test should fail.
@tzdybal
feat: add DA height tracking to sequencer
1b5b783 
WIP. `lastBatchHash` is still ignored, but sequencer is traversing DA.
@tzdybal
test: add batch hashing
cae2b5b
@tzdybal
feat: introduce Store interface
98a99e1
@tzdybal
refactor: rename BasedSequencer receiver
5b30e6f
@tzdybal
refactor: update sequencing methods to use go-sequencing v0.2.0
c63a9ba 
Refactored methods to use request/response structures for better readability and maintainability. Adjusted tests accordingly.
@tzdybal
feat: implement KVStore
e1b4820 
add in-memory badger based store used for testing
@tzdybal
refactor: replace go-datastore with native badger DB
d4e78b6 
Migrated all store operations from go-datastore to Badger DB. This simplifies the codebase by removing unnecessary abstractions and leveraging native Badger functionalities for better performance and maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tzdybal tzdybal

Labels
enhancement New feature or request
Projects
Rollkit
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement GetNextBatch Implement SubmitRollupTransaction
1 participant
@tzdybal